Create a WASM package #1389
Merged
Create a WASM package #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Instead of having to manually download and update libSkiaSharp.a for WASM, just depend on the
SkiaSharp.NativeAssets.WebAssemblypackage. This doesn't do anything except expose a path to the actuallibSkiaSharp.awhich you can then use in whatever tooling you need.There are 2 ways to do this:
$(SkiaSharpStaticLibraryPath)@(SkiaSharpStaticLibrary)Another way to use this package is as a build-time dependency. Since you have the path to the package, you can add it as an embedded resource or copy it to the output as content. To prevent a dependency with
dotnet pack, just mark the<PackageReference>with aPrivateAssets="all"property. Then only you will see it in that project.