Merge pull request jashkenas#2519 from CodeFalling/fix-isnan-error-sy…

…mbols fix _.isNaN errors on symbols
monkpow · Apr 28, 2016 · 28e9704 · 28e9704
2 parents 1e68f06 + e1741ab
commit 28e9704
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/test/objects.js b/test/objects.js
@@ -844,6 +844,9 @@
     assert.notOk(_.isNaN(new Number(0)), 'wrapped 0 is not NaN');
     assert.ok(_.isNaN(NaN), 'but NaN is');
     assert.ok(_.isNaN(new Number(NaN)), 'wrapped NaN is still NaN');
+    if (typeof Symbol !== 'undefined'){
+      assert.notOk(_.isNaN(Symbol()), 'symbol is not NaN');
+    }
   });
 
   QUnit.test('isNull', function(assert) {

diff --git a/underscore.js b/underscore.js
@@ -1320,7 +1320,7 @@
 
   // Is the given value `NaN`?
   _.isNaN = function(obj) {
-    return isNaN(obj) && _.isNumber(obj);
+    return _.isNumber(obj) && isNaN(obj);
   };
 
   // Is a given value a boolean?