feat: allow user to use local file as background (@fehmer, @byseif21, @miodec) #6663

fehmer · 2025-06-25T16:12:53Z

Allow the user to use a local file as custom background without uploading it to the server.

Based on @byseif21 work in #6630, thanks!

byseif21 · 2025-06-25T17:24:40Z

frontend/src/ts/pages/settings.ts

-).on("click", () => {
+).on("click", async () => {
+  if (Config.customBackground === "localBackgroundFile") {
+    await FileStorage.deleteFile("localBackgroundFile");


just a small thing when deleting the local background, the input box will still show the previous text. would it be good to add

$(".pageSettings .section[data-config-name='customBackgroundSize'] .inputAndButton input.input").val("");

or something to clear it since it's not reusable like the url ? if you understand what i mean

yeah, thanks.

byseif21 · 2025-06-25T17:28:41Z

hey @fehmer thanks and yah very nice , just don't we forget to update the setting description too. or you think the aria-label enough ?

byseif21 · 2025-06-25T17:43:29Z

also didn't we still need to add a file size check before storing?

fehmer · 2025-06-25T17:52:24Z

hi @byseif21 , thanks for your comments. I updated the description and icon to match the same as "open file" in custom text settings. An upload icon might be confusing.

I don't think we need a file size check, the limit for idb is like 20gig or 10% of the users disc space, so we should be fine.

github-actions · 2025-06-26T23:13:02Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions · 2025-06-27T00:10:29Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

frontend/src/ts/constants/default-config.ts

fixes #6789

### Description This PR adds language support for the ABAP programming language. It adds code_abap with the 200 most used ABAP keywords and code_abap_1k with all ABAP keywords from the current ABAP language version. ### Checks - [x] Adding a language? - Make sure to follow the [languages documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LANGUAGES.md) - [x] Add language to `packages/schemas/src/languages.ts` - [x] Add language to exactly one group in `frontend/src/ts/constants/languages.ts` - [x] Add language json file to `frontend/static/languages` - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@byseif21

@byseif21) (#6581) ### Description When (changing / adding or removing themes from favorite ) via command line or from the current theme button "in page e.g test page" and then navigating to Settings > Themes, the UI does not immediately reflect the current theme changes . The user has to manually refresh the page to see these changes. **Now** UI automatically refreshes to reflect the current theme selection and favorites without requiring a manual page refresh. - Added refreshThemeUI function in theme-picker.ts that updates all theme-related UI components - Called this refresh function in the settings page's beforeShow lifecycle hook to ensure the theme UI is always up-to-date when the page is displayed. **FOR TESTING BEFORE & AFTER:** keep changing themes then navigate to the settings and check and keep doing those things again to verify that the active theme and favorites update. --------- Co-authored-by: Miodec <jack@monkeytype.com>

github-actions · 2025-07-27T18:10:28Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions · 2025-07-27T18:31:22Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

Miodec

Thanks

…Miodec

…Miodec) (#6663) Allow the user to use a local file as custom background without uploading it to the server. Based on @byseif21 work in #6630, thanks! --------- Co-authored-by: Miodec <jack@monkeytype.com> Co-authored-by: Lukas <dev@mardybum.de> Co-authored-by: Seif Soliman <byseif21@gmail.com>

monkeytypegeorge added frontend User interface or web stuff packages Changes in local packages labels Jun 25, 2025

fehmer added force-ci Force CI to run on draft PRs and removed frontend User interface or web stuff labels Jun 25, 2025

feat: allow user to use local file as background (@fehmer, @byseif21)

3a1dcbd

fehmer force-pushed the feature/use-local-files-for-background branch from 15b5376 to 3a1dcbd Compare June 25, 2025 16:14

monkeytypegeorge added the frontend User interface or web stuff label Jun 25, 2025

remove file from storage, handle missing file from storage

b88bd84

fehmer marked this pull request as ready for review June 25, 2025 16:30

github-actions bot added the waiting for review Pull requests that require a review before continuing label Jun 25, 2025

byseif21 reviewed Jun 25, 2025

View reviewed changes

github-actions bot removed the waiting for review Pull requests that require a review before continuing label Jun 25, 2025

clear text input on clear button, update description and icon

78524cd

use local background file if available, don't store in config

9a0d642

monkeytypegeorge removed the packages Changes in local packages label Jun 26, 2025

github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jun 26, 2025

circle

c2059f0

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jun 27, 2025

github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jun 27, 2025

test

2d21ac3

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jun 27, 2025

fehmer commented Jun 27, 2025

View reviewed changes

frontend/src/ts/constants/default-config.ts Outdated Show resolved Hide resolved

Miodec and others added 3 commits July 27, 2025 19:48

Merge branch 'master' into feature/use-local-files-for-background

b28b023

fix(login): clear data on logout (@fehmer) (#6791)

df1bb45

fixes #6789

byseif21 and others added 2 commits July 27, 2025 20:08

fix: custom background not working

4163f38

monkeytypegeorge added assets Languages, themes, layouts, etc. packages Changes in local packages labels Jul 27, 2025

github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 27, 2025

Merge branch 'master' into feature/use-local-files-for-background

ae12e60

monkeytypegeorge removed assets Languages, themes, layouts, etc. packages Changes in local packages labels Jul 27, 2025

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 27, 2025

github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 27, 2025

fix

b6363d2

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jul 28, 2025

Miodec added 4 commits July 28, 2025 12:00

add module to handle the custom background picker

7528e97

use hasfile

050d25d

remove unnecessary function

8277b80

remove constant, strict types for filenames

56b8072

Miodec changed the title ~~feat: allow user to use local file as background (@fehmer, @byseif21)~~ feat: allow user to use local file as background (@fehmer, @byseif21, @miodec) Jul 28, 2025

Miodec added 6 commits July 28, 2025 12:17

remove unused code

4bd1910

unused code

27d1a14

rename

35c9dd0

bandaid

44b1489

stroing

d16dea6

note

675ead8

Miodec approved these changes Jul 28, 2025

View reviewed changes

Miodec merged commit f2b34a5 into master Jul 28, 2025
12 checks passed

Miodec deleted the feature/use-local-files-for-background branch July 28, 2025 10:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: allow user to use local file as background (@fehmer, @byseif21, @miodec) #6663

feat: allow user to use local file as background (@fehmer, @byseif21, @miodec) #6663

fehmer commented Jun 25, 2025

Uh oh!

byseif21 Jun 25, 2025

Uh oh!

fehmer Jun 25, 2025

Uh oh!

byseif21 commented Jun 25, 2025

Uh oh!

byseif21 commented Jun 25, 2025

Uh oh!

fehmer commented Jun 25, 2025

Uh oh!

github-actions bot commented Jun 26, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 27, 2025

Uh oh!

github-actions bot commented Jul 27, 2025

Uh oh!

Miodec left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: allow user to use local file as background (@fehmer, @byseif21, @miodec) #6663

feat: allow user to use local file as background (@fehmer, @byseif21, @miodec) #6663

Conversation

fehmer commented Jun 25, 2025

Uh oh!

byseif21 Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

fehmer Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

byseif21 commented Jun 25, 2025

Uh oh!

byseif21 commented Jun 25, 2025

Uh oh!

fehmer commented Jun 25, 2025

Uh oh!

github-actions bot commented Jun 26, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 27, 2025

Uh oh!

github-actions bot commented Jul 27, 2025

Uh oh!

Miodec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!