refactor(hints): improve readability of hints functions (@NadAlaba) #6629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NadAlaba
force-pushed
the
refactor-hints-functions
branch
from
cec0a09 to
5d74fc1
Compare
github-actions
bot
added
the
waiting for review
NadAlaba
force-pushed
the
refactor-hints-functions
branch
from
5d74fc1 to
4059ea1
Compare
NadAlaba
changed the title
NadAlaba
force-pushed
the
refactor-hints-functions
branch
from
4059ea1 to
074c956
Compare
NadAlaba
force-pushed
the
refactor-hints-functions
branch
from
074c956 to
8b0a503
Compare
NadAlaba
force-pushed
the
refactor-hints-functions
branch
from
8b0a503 to
6c1a4f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
joinOverlappingHints()solves the issue of hints joining when they correspond to letters of different lines, which was one of the issues #6636 was supposed to solve.