Skip to content

impr(results): allow stopOnError:letter while it's master mode (@byseif21) #6611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

impr(results): allow stopOnError:letter while it's master mode (@byseif21) #6611

wants to merge 6 commits into from
+17 −4

Conversation

byseif21
Copy link
Contributor

@byseif21 byseif21 commented Jun 3, 2025 •
edited
Loading

Description

close #6609

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jun 3, 2025
@Miodec
Copy link
Member

Miodec commented Jun 4, 2025

You need to add this special case to the backend too. Backend receives stopOnLetter: boolean.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Jun 4, 2025
@monkeytypegeorge monkeytypegeorge added the backend Server stuff label Jun 4, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jun 4, 2025
@byseif21
Copy link
Contributor Author

byseif21 commented Jun 4, 2025

You need to add this special case to the backend too. Backend receives stopOnLetter: boolean.

Done!

@byseif21 byseif21 marked this pull request as draft June 4, 2025 13:21
@byseif21 byseif21 marked this pull request as ready for review June 4, 2025 14:03
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jun 4, 2025
@byseif21 byseif21 changed the title impr(results): allow stopOnError while it's master mode (@byseif21) impr(results): allow stopOnError:letter while it's master mode (@byseif21) Jun 5, 2025
@Miodec
Copy link
Member

Miodec commented Jun 23, 2025

Now that im thinking about this, maybe the unique case here should be 100% accuracy and not difficulty?

@Miodec Miodec added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend Server stuff frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stop on letter vs master
3 participants
@byseif21 @Miodec @monkeytypegeorge