Skip to content

impr(quotes): Add English quotes from Andor S1 (@j5155) #6585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

j5155
Copy link

@j5155 j5155 commented May 21, 2025

Description

I added some quotes of various lengths from Andor season 1.

Checks

  • Adding quotes?

    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?

    • Make sure to follow the languages documentation
    • Add language to packages/contracts/src/schemas/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?

    • Make sure to follow the themes documentation
    • Add theme to packages/contracts/src/schemas/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • Add theme css file to frontend/static/themes
  • Adding a layout?

    • Make sure to follow the layouts documentation
    • Add layout to packages/contracts/src/schemas/layouts.ts
    • Add layout json file to frontend/static/layouts
    • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.

  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)

  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels May 21, 2025
@Miodec
Copy link
Member

Miodec commented May 26, 2025

Could you update the quote sources to a xxx, Andor Season 1 format?

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label May 26, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label May 26, 2025
@j5155
Copy link
Author

j5155 commented May 26, 2025

Sounds good, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants