refactor: move common util functions to a package (@miodec) #5894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeytypegeorge
added
backend
Miodec
changed the title
Miodec
changed the title
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
NadAlaba
reviewed
Sep 18, 2024
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
fehmer
reviewed
Sep 20, 2024
backend/tsconfig.json
Outdated
| @@ -11,8 +11,7 @@ | |||
| "ts-node": { | |||
| "files": true | |||
| }, | |||
| "files": ["./src/types/types.d.ts"], | |||
| "include": ["./src/**/*"], | |||
| "include": ["src", "scripts"], | |||
There was a problem hiding this comment.
not sure if this makes a difference or not.
scripts is not part of the deployed application. Should it be part of the typescript config? We have a tsconfig in https://github.com/monkeytypegame/monkeytype/blob/master/backend/scripts/tsconfig.json same as we handle it for __tests__.
fehmer
previously approved these changes
Sep 20, 2024
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
github-actions
bot
added
the
waiting for review
fehmer
approved these changes
Sep 20, 2024
github-actions
bot
removed
the
waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves esbuild to a package.