Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename scripts to ts #2869

Merged
merged 5 commits into from
Apr 24, 2022
Merged

Rename scripts to ts #2869

merged 5 commits into from
Apr 24, 2022

Conversation

Ferotiq
Copy link
Member

@Ferotiq Ferotiq commented Apr 24, 2022

Description

Closes #

@Ferotiq Ferotiq added backend Server stuff frontend User interface or web stuff local dev Related to the build process or dependencies labels Apr 24, 2022
@rizwanmustafa
Copy link
Member

Please add firebase-config.ts to gitignore.

@Ferotiq
Copy link
Member Author

Ferotiq commented Apr 24, 2022

it's there... I have no idea why it's going through

@Ferotiq
Copy link
Member Author

Ferotiq commented Apr 24, 2022

now it works... wtf

@rizwanmustafa
Copy link
Member

Remove it from gitignore. Delete it, add deletion change. Commit and then add to gitignore and then add the actual file back.

@Ferotiq
Copy link
Member Author

Ferotiq commented Apr 24, 2022

luckily the firebase-config isn't important to release to the public

@rizwanmustafa
Copy link
Member

Yeah

@Ferotiq Ferotiq requested a review from Miodec April 24, 2022 14:18
@Miodec
Copy link
Member

Miodec commented Apr 24, 2022

Looks good, will merge after #2862

@Miodec Miodec merged commit f584d68 into dev Apr 24, 2022
@Miodec Miodec deleted the rename branch April 24, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec approved these changes

Assignees
No one assigned
Labels
backend Server stuff frontend User interface or web stuff local dev Related to the build process or dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ferotiq @rizwanmustafa @Miodec