Skip to content

Commit

Permalink
*: Use exponential buckets for histogram metrics (thanos-io#1545)
Browse files Browse the repository at this point in the history
* Use exponential buckets for compactor histogram metrics

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Update buckets

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Adjust histogram buckets

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Adjust store gate bucket

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>

* Adjust http duration buckets

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Aleksey Sin <asin@ozon.ru>
  • Loading branch information
kakkoyun authored and Aleksey Sin committed Nov 27, 2019
1 parent 026199d commit cabcc41
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions cmd/thanos/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,7 @@ func registerQuery(m map[string]setupFunc, app *kingpin.Application) {
func storeClientGRPCOpts(logger log.Logger, reg *prometheus.Registry, tracer opentracing.Tracer, secure bool, cert, key, caCert, serverName string) ([]grpc.DialOption, error) {
grpcMets := grpc_prometheus.NewClientMetrics()
grpcMets.EnableClientHandlingTimeHistogram(
grpc_prometheus.WithHistogramBuckets([]float64{
0.001, 0.01, 0.05, 0.1, 0.2, 0.4, 0.8, 1.6, 3.2, 6.4,
}),
grpc_prometheus.WithHistogramBuckets(prometheus.ExponentialBuckets(0.001, 2, 15)),
)
dialOpts := []grpc.DialOption{
// We want to make sure that we can receive huge gRPC messages from storeAPI.
Expand Down

0 comments on commit cabcc41

Please sign in to comment.