add dhcp_hostname config for esp32 #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpq
reviewed
Feb 5, 2021
src/esp32/esp32_eth.c
Outdated
| @@ -126,6 +137,12 @@ bool mgos_ethernet_init(void) { | |||
| return false; | |||
| } | |||
|
|
|||
| ret = esp32_set_host_name(mgos_sys_config_get_eth()); | |||
There was a problem hiding this comment.
I would set host name only if it is explicitely set in the configuration:
if (mgos_sys_config_get_eth_dhcp_hostname() != NULL &&
esp_netif_set_hostname(esp_netif_get_handle_from_ifkey("ETH_DEF"),
mgos_sys_config_get_eth_dhcp_hostname()) != ESP_OK) {
LOG(LL_ERROR, ("ETH: Failed to set host name"));
goto out;
}There was a problem hiding this comment.
Should be fixed now, thanks for the advice. master...ALLTERCO:master
There was a problem hiding this comment.
i think the function can be inlined since it's only used once. you already have the netif handle in eth_if here
|
Strangely, pushing new versions of the commit doesn't reflect this pull request. Let's close this, I'll open a fresh one from a branch in our fork. |
|
Closing this, as #6 was pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.