improve script and test

.github/workflows/test.yml

@@ -11,21 +11,31 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - id: action-success-test
+        name: action-success-test
         uses: ./
         with:
           github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
           reporter: github-check
           level: error
-          workdir: ./testdata
+          filter_mode: nofilter
+          fail_on_error: true
           biome_flags: ok
       - id: action-failure-test
+        name: action-failure-test
         uses: ./
+        continue-on-error: true
         with:
           github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
           reporter: github-check
           level: info
-          workdir: ./testdata
+          filter_mode: nofilter
+          fail_on_error: true
           biome_flags: error
+      - name: check-failure
+        if: steps.action-failure-test.outcome == 'success'
+        run: exit 1
 
   test-pr-check:
     if: github.event_name == 'pull_request'
@@ -34,21 +44,31 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - id: action-success-test
+        name: action-success-test
         uses: ./
         with:
           github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
           reporter: github-pr-check
           level: error
-          workdir: ./testdata
+          filter_mode: nofilter
+          fail_on_error: true
           biome_flags: ok
       - id: action-failure-test
+        name: action-failure-test
         uses: ./
+        continue-on-error: true
         with:
           github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
           reporter: github-pr-check
           level: info
-          workdir: ./testdata
+          filter_mode: nofilter
+          fail_on_error: true
           biome_flags: error
+      - name: check-failure
+        if: steps.action-failure-test.outcome == 'success'
+        run: exit 1
 
   test-pr-review:
     if: github.event_name == 'pull_request'
@@ -57,18 +77,28 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - id: action-success-test
+        name: action-success-test
         uses: ./
         with:
           github_token: ${{ secrets.github_token }}
+          workdir: ./testdata
           reporter: github-pr-review
           level: error
-          workdir: ./testdata
+          filter_mode: nofilter
+          fail_on_error: true
           biome_flags: ok
       - id: action-failure-test
+        name: action-failure-test
         uses: ./
+        continue-on-error: true
         with:
           github_token: ${{ secrets.github_token }}
-          reporter: github-pr-check
-          level: info
           workdir: ./testdata
+          reporter: github-pr-review
+          level: info
+          filter_mode: nofilter
+          fail_on_error: true
           biome_flags: error
+      - name: check-failure
+        if: steps.action-failure-test.outcome == 'success'
+        run: exit 1

script.sh

@@ -21,21 +21,21 @@ fi
 echo "Biome $("$(npm root)"/.bin/biome --version)"
 
 echo '::group:: Running Biome with reviewdog 🐶 ...'
-"$(npm root)"/.bin/biome ci "${INPUT_BIOME_FLAGS}" |
+"$(npm root)"/.bin/biome ci "${INPUT_BIOME_FLAGS}" 2>&1 |
   reviewdog \
-    -efm="%E%f:%l:%c %m ━%r" \
     -efm="%C" \
+    -efm="%-Gci ━%#" \
+    -efm="%E%f:%l:%c %.%#━" \
     -efm="%Z  × %m" \
-    -efm="%E%f %m ━%r" \
-    -efm="%C" \
+    -efm="%E%f %m %.%#━" \
     -efm="%Z  × %m" \
     -efm="%-G%.%#" \
     -name="${INPUT_TOOL_NAME}" \
     -reporter="${INPUT_REPORTER}" \
     -filter-mode="${INPUT_FILTER_MODE}" \
     -fail-on-error="${INPUT_FAIL_ON_ERROR}" \
     -level="${INPUT_LEVEL}" \
-    ${INPUT_REVIEWDOG_FLAGS}
+    "${INPUT_REVIEWDOG_FLAGS}"
 exit_code=$?
 echo '::endgroup::'
 exit $exit_code

testdata/error/format.js

@@ -1,5 +1 @@
-let a = [,];
-let b = [,,];
-let c = [,,1,];
-let d = [,,1,1];
-let e = [2,2,1,3];
+const a = [2,2,1,3];

testdata/ok/format.js

@@ -1,5 +1 @@
-let a = [,];
-let b = [, ,];
-let c = [, , 1];
-let d = [, , 1, 1];
-let e = [2, 2, 1, 3];
+const a = [2, 2, 1, 3];

testdata/ok/lint.js

@@ -1,4 +1 @@
 [foo, bar] = baz;
-[,,,b,,c,] = baz;
-[a = "test", a.b, call().b] = baz;
-[((a))] = baz;