Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we find the correct Regexp::Raw class #240

Merged
merged 2 commits into from
Apr 6, 2017

Conversation

artfuldodger
Copy link
Contributor

With mongoid 5.2.1's addition of the Origin::Extensions::Regexp::Raw module,
the constant lookup was ambiguous.

Here's the exception I was seeing:

NoMethodError:
  undefined method `new' for Origin::Extensions::Regexp::Raw:Module
# /home/rof/cache/bundler/ruby/2.4.0/gems/mongoid-slug-5.3.2/lib/mongoid/slug/unique_slug.rb:133:in `regex_for_slug'

With mongoid 5.2.1's addition of the Origin::Extensions::Regexp::Raw module,
the constant lookup was ambiguous.
@mongoid-bot
Copy link

mongoid-bot commented Apr 5, 2017

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@@ -1,4 +1,5 @@
## 5.3.2 (Next)
* [#240](https://github.com/mongoid/mongoid-slug/pull/240): Ensure we find the correct Regexp::Raw class - [@artfuldodger](https://github.com/artfuldodger).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny: Maybe add a space above?

@dblock dblock merged commit bdc47fd into mongoid:master Apr 6, 2017
@dblock
Copy link
Collaborator

dblock commented Apr 6, 2017

Merged thanks, @mzikherman want to cut an update?

@mzikherman
Copy link
Collaborator

Yup, will release this as 5.3.3, thanks for fixing @artfuldodger!

@mzikherman
Copy link
Collaborator

Released as 5.3.3.

@dblock dblock mentioned this pull request Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants