Skip to content

chore: Adds empty values when auto_scaling is not defined #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: CLOUDP-308783_plan_modify_replication_specs
Choose a base branch
from

Conversation

EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented Apr 1, 2025

Description

  • Adds empty values when auto_scaling is not defined, to ensure we don't get the auto_scaling must be present in every region config error
  • Full Test Run Only TestAccClusterFlexCluster_basic failing, will re-run it
  • Re-run for TestAccClusterFlexCluster_basic

Link to any related issue(s): CLOUDP-308783

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert EspenAlbert marked this pull request as ready for review April 1, 2025 15:48
@EspenAlbert EspenAlbert requested a review from a team as a code owner April 1, 2025 15:48
@@ -95,8 +95,16 @@ type rs struct {

// ModifyPlan is called before plan is shown to the user and right before the plan is applied.
// Why do we need this? Why can't we use planmodifier.UseStateForUnknown in different fields?
// 1. UseStateForUnknown always copies the state for unknown values. However, that leads to `Error: Provider produced inconsistent result after apply` in some cases (see implementation below).
// 2. Adding the different UseStateForUnknown is very verbose.
// 1. `UseStateForUnknown` always copies the state for unknown values. However, that leads to `Error: Provider produced inconsistent result after apply` in some cases (see implementation below).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guide for new attributes and update

Copy link
Contributor

github-actions bot commented Apr 7, 2025

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Apr 7, 2025
@github-actions github-actions bot closed this Apr 10, 2025
@EspenAlbert EspenAlbert added the not_stale Not stale issue or PR label Apr 10, 2025
@EspenAlbert EspenAlbert reopened this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not_stale Not stale issue or PR stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant