Skip to content

REALMC-5421: Add get branches route #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020

Conversation

haleyowen
Copy link
Contributor

No description provided.

@haleyowen haleyowen requested a review from joshmadewell May 13, 2020 04:58
src/admin.js Outdated
@@ -256,6 +256,13 @@ export class StitchAdminClient extends StitchClient {
get: commit => api._get(`${appUrl}/deployments/${commit}`)
}),
installation: () => api._get(`${appUrl}/deploy/installation`),
repositories: repoId => ({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be:

repositories.repository(id).github().branches().list()

repositories: () => ({
  repository: (repoId) => ({
    github: () => ({
      branches: () => ({
        list: () => ({
          return api._get...    
        }),
      }),
    }),
  });
}),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we did the other one this way so that if we added another provider like bitbucket we could just add it to the end instead of copying all of it again? I was trying to keep this consistent with the auth route

@haleyowen haleyowen merged commit 0c2b5e3 into mongodb:support/3.x May 21, 2020
@haleyowen haleyowen deleted the REALMC-5421 branch May 21, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants