DRIVERS-3483 Clarify BulkWrite pre-flight check timing in collation spec#1941
Open
GromNaN wants to merge 2 commits into
Open
DRIVERS-3483 Clarify BulkWrite pre-flight check timing in collation spec#1941GromNaN wants to merge 2 commits into
GromNaN wants to merge 2 commits into
Conversation
The second paragraph after the BulkWrite example used lowercase "must" (non-RFC 2119) and did not repeat the "MUST NOT send any operations" condition, leaving the rejection timing ambiguous (pre-flight vs. on first encountered error). Replace with uppercase MUST and explicitly restate that all operations MUST be inspected before any are sent to the server.
GromNaN
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/DRIVERS-3483
The paragraph following the BulkWrite example used lowercase
must(not RFC 2119 normative) and did not repeat theMUST NOT send any operationscondition, making the rejection timing ambiguous:A driver could read this as: iterate and send operations one by one, failing when it hits one with a Collation. The first paragraph already says
MUST NOT send any operations to the server, but the repetition with weaker language introduced doubt.Replace with RFC 2119
MUSTand make the pre-flight nature explicit: all operations MUST be inspected before any are sent.