DRIVERS-3482 Remove stale secondaryOk=true requirement from getMore section#1940
Open
GromNaN wants to merge 1 commit into
Open
DRIVERS-3482 Remove stale secondaryOk=true requirement from getMore section#1940GromNaN wants to merge 1 commit into
GromNaN wants to merge 1 commit into
Conversation
GromNaN
force-pushed
the
fix/find-getmore-secondaryok
branch
from
8969932 to
07f29c2
Compare
The getMore section stated "The query flags passed to OP_QUERY for a getMore command MUST be secondaryOk=true when sent to a secondary." This contradicted the "Interactions with OP_QUERY" section which stated "secondaryOk SHOULD not be set for follow-up getMore and killCursors commands." Commit 1aabad4 (2015-10-17) reversed the original 2015-09-30 decision and updated the spec body and changelog accordingly, but missed this sentence in the getMore section. Remove it to align with the SHOULD NOT rule that has been in effect since 2015-10-13.
GromNaN
force-pushed
the
fix/find-getmore-secondaryok
branch
from
07f29c2 to
e47fc42
Compare
GromNaN
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/DRIVERS-3482
The
getMoresection contained this sentence:This directly contradicted the "Interactions with OP_QUERY" section of the same spec:
The two changelog entries tell the history:
Commit 1aabad4 (2015-10-17) applied the reversal by updating the spec body and the changelog, but missed the sentence in the
getMoresection. That sentence has been inconsistent with the rest of the spec for ten years.No behaviour change intended — the SHOULD NOT rule in the "Interactions with OP_QUERY" section has been the stated intent since 2015-10-13.