DRIVERS-3344 - Add support for server selection's deprioritized servers to all topologies #1865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs to all topologies
NoahStapp
requested review from
jmikola,
jyemin and
vector-of-bool
and removed request for
a team
blink1073
approved these changes
Dec 9, 2025
Member
blink1073
left a comment
blink1073
left a comment
There was a problem hiding this comment.
Changes LGTM from a backpressure standpoint
.../server-selection/tests/server_selection/ReplicaSetWithPrimary/read/DeprioritizedPrimary.yml
Show resolved
Hide resolved
...erver-selection/tests/server_selection/ReplicaSetWithPrimary/read/DeprioritizedSecondary.yml
Show resolved
Hide resolved
...ction/tests/server_selection/ReplicaSetWithPrimary/write/DeprioritizedSecondaryPreferred.yml
Show resolved
Hide resolved
baileympearson
requested changes
Dec 10, 2025
eramongodb
requested changes
Dec 10, 2025
baileympearson
approved these changes
Dec 11, 2025
eramongodb
approved these changes
Dec 11, 2025
Contributor
eramongodb
left a comment
eramongodb
left a comment
There was a problem hiding this comment.
Minor suggestions remaining; otherwise, LGTM.
blink1073
approved these changes
Dec 11, 2025
sleepyStick
approved these changes
Dec 11, 2025
Contributor
sleepyStick
left a comment
sleepyStick
left a comment
There was a problem hiding this comment.
LGTM!
love the "Why does server deprioritization use only server addresses and not ServerDescription objects?" section too!
isabelatkinson
approved these changes
Dec 11, 2025
Contributor
isabelatkinson
left a comment
isabelatkinson
left a comment
There was a problem hiding this comment.
retryability changes LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the server selection process to require server deprioritization on retries across all topologies. The summary of these changes are:
clusters).