DRIVERS-2295 Convert CSFLE spec tests to unified test format #1784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Albertson <kevin.albertson@10gen.com>
kevinAlbs
reviewed
Apr 11, 2025
kevinAlbs
reviewed
Apr 22, 2025
mdb-ad
requested review from
alcaeus,
nbbeeken,
katcharov,
kevinAlbs,
jyemin and
ShaneHarvey
and removed request for
a team
kevinAlbs
reviewed
Jun 9, 2025
kevinAlbs
requested review from
kevinAlbs
and removed request for
alcaeus and
nbbeeken
kevinAlbs
reviewed
Jun 10, 2025
source/client-side-encryption/tests/legacy/fle2v2-BypassQueryAnalysis.json
Outdated
Show resolved
Hide resolved
kevinAlbs
requested review from
rozza
and removed request for
katcharov and
jyemin
Co-authored-by: Kevin Albertson <kevin.eric.albertson@gmail.com>
kevinAlbs
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
LGTM. @ShaneHarvey and @rozza may I request trying these tests in Python and/or Java? That might help gain more confidence in the migrated tests work in case there are quirks in the C driver test runner. Unified test format changes to add support for autoEncryptOpts are in DRIVERS-3106.
rozza
requested changes
Jul 28, 2025
baileympearson
requested changes
Jul 28, 2025
There was a problem hiding this comment.
This is a little bit last minute but #1823 (comment) is considering implementing a minLibmongocryptVersion runOnRequirement for FLE tests. If we do accept that change to the unified test format, could we also add min libmongocrypt version requirements to the new tests in this PR?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: some legacy tests were skipped by the C driver. The unified version is also untested.
$typeand C driver failing to parse: CDRIVER-3387).C driver Evergreen
New tests depend on unified test runner changes from DRIVERS-3106.