Skip to content

Reformat RST for Atlas Search prose tests #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Reformat RST for Atlas Search prose tests #1458

merged 1 commit into from
Aug 31, 2023

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Aug 29, 2023

While reviewing mongodb/mongo-php-library#1097 I noticed several formatting issues in RST for Atlas Search prose tests. Most notably, the code blocks within each test were not indented correctly and caused the steps to reset from one.

This PR follows a previous commit to fix an RST issue: 53303dd

@jmikola jmikola requested a review from baileympearson August 29, 2023 23:17
@jmikola jmikola requested a review from a team as a code owner August 29, 2023 23:17
@jmikola jmikola requested review from dariakp and removed request for a team August 29, 2023 23:17
@jmikola jmikola changed the title Reformat RST for prose tests Reformat RST for Atlas Search prose tests Aug 29, 2023
- An index with the ``name`` of ``test-search-index`` is present. This index is referred to as ``index``.
- The index has a field ``queryable`` with a value of ``true`` and has a field ``status`` with the value of ``READY``.

#. Assert that an index is present with the name ``test-search-index`` and the definition has a property ``latestDefinition`` whose value is ``{ 'mappings': { 'dynamic': true } }``.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, this could have been fixed by adjusting the wrapping on the second line; however, other steps in this file used a single line so I did so here for consistency.

@jmikola jmikola merged commit b88f800 into master Aug 31, 2023
@jmikola jmikola deleted the jmikola-patch-2 branch August 31, 2023 11:42
@jmikola jmikola restored the jmikola-patch-2 branch August 31, 2023 11:42
@jmikola jmikola deleted the jmikola-patch-2 branch August 31, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants