Skip to content

DRIVERS-2415 OIDC SASL Clarifications #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 60 commits into from
Apr 29, 2023
Merged

DRIVERS-2415 OIDC SASL Clarifications #1381

merged 60 commits into from
Apr 29, 2023

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 28, 2023 •
edited
Loading

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@blink1073 blink1073 requested review from a team as code owners February 28, 2023 16:33
@blink1073 blink1073 requested review from JamesKovacs and alcaeus and removed request for a team February 28, 2023 16:33
@blink1073
Copy link
Member Author

cc @dima @durran

durran
durran requested changes Feb 28, 2023
View reviewed changes
@blink1073 @durran
Update source/auth/auth.rst
ababbe3 
Co-authored-by: Durran Jordan <durran@gmail.com>
@blink1073 blink1073 requested a review from durran February 28, 2023 19:41
DmitryLukyanov
DmitryLukyanov reviewed Mar 1, 2023
View reviewed changes
DmitryLukyanov
DmitryLukyanov reviewed Mar 3, 2023
View reviewed changes
DmitryLukyanov
DmitryLukyanov approved these changes Mar 14, 2023
View reviewed changes
Copy link

@DmitryLukyanov DmitryLukyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blink1073 and others added 5 commits April 26, 2023 18:35
@blink1073 @addaleax
Update source/auth/auth.rst
2a1cd15 
Co-authored-by: Anna Henningsen <github@addaleax.net>
@blink1073 @katcharov
Update source/auth/auth.rst
ed839cc 
Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
@blink1073 @katcharov
Update source/auth/auth.rst
21d0417 
Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com>
@blink1073
address review
9712105
@blink1073
clarify lock behavior
0d33844
addaleax
addaleax approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge for me.

katcharov
katcharov reviewed Apr 27, 2023
View reviewed changes
katcharov
katcharov reviewed Apr 27, 2023
View reviewed changes
katcharov
katcharov approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

durran
durran requested changes Apr 27, 2023
View reviewed changes
durran
durran requested changes Apr 28, 2023
View reviewed changes
blink1073 and others added 3 commits April 28, 2023 13:26
@blink1073 @durran
Update source/auth/tests/mongodb-oidc.rst
fe9a2a6 
Co-authored-by: Durran Jordan <durran@gmail.com>
@blink1073 @durran
Update source/auth/tests/mongodb-oidc.rst
4d68b51 
Co-authored-by: Durran Jordan <durran@gmail.com>
@blink1073 @durran
Update source/auth/tests/mongodb-oidc.rst
ec2d0e9 
Co-authored-by: Durran Jordan <durran@gmail.com>
JamesKovacs
JamesKovacs approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Noted some minor typos.

source/auth/auth.rst Outdated

Using the socket address and port accounts for the case when two different
servers use the same username but could be configurated differently.
MUST also include a hashes of the callback function(s), if hash comparisons are possible in the driver language. In the case of a global cache, Using the socket address and port accounts for the case when two different servers use the same username but could be configured differently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a hashes => hashes
Using => using

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@blink1073 blink1073 merged commit 5112bcc into mongodb:master Apr 29, 2023
@blink1073 blink1073 deleted the DRIVERS-2415-2 branch April 29, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitryLukyanov DmitryLukyanov DmitryLukyanov approved these changes

@durran durran durran approved these changes

@katcharov katcharov katcharov approved these changes

@JamesKovacs JamesKovacs JamesKovacs approved these changes

@alcaeus alcaeus alcaeus approved these changes

@addaleax addaleax addaleax approved these changes

@baileympearson baileympearson Awaiting requested review from baileympearson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@blink1073 @durran @katcharov @JamesKovacs @alcaeus @addaleax @baileympearson @DmitryLukyanov