relax logging to allow expected to subset actual #1372
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating the logs, it could be the case that there are more "actual" logs being queued than "expected" logs. For example, the Go Driver closes sessions when the client is disconnected which triggers three extra checkout logs than are expected in the CMAP UST. In this case, the unified test will result in |actual| = |expected| + 3 and fail.
It seems realistic to assume that most drivers will have "noisy"/"extra" logs while running unified spec tests. To be more precise, a valid case could meet the condition such that |actual| >= |expected| > 0. Perhaps we should relax the conditions on what it means for "expected" to match "actual". Instead of an exact match, we could require that expected messages be an "ordered subset" of the actual messages.