ci(NODE-5125): fix flaky case 14 prose test #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
added
the
Primary Review
durran
previously approved these changes
Aug 22, 2023
durran
added
Team Review
baileympearson
force-pushed
the
NODE-5125-flaky-decryption-prose-test
branch
from
668f6f3 to
daa2320
Compare
nbbeeken
requested changes
Aug 22, 2023
...integration/client-side-encryption/client_side_encryption.prose.14.decryption_events.test.ts
Outdated
Show resolved
Hide resolved
...integration/client-side-encryption/client_side_encryption.prose.14.decryption_events.test.ts
Outdated
Show resolved
Hide resolved
durran
approved these changes
Aug 22, 2023
nbbeeken
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
We missed a spec commit that fixed FLE prose test 14.
This PR updates the test setup to set the last byte of the malformed ciphertext to a different value instead of always setting it to 0 because sometimes the HMAC tag happens to end in 0.
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript