Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(NODE-5532): fix docs for types and regenerate 5.7 docs #3822

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

Our .gitignore was ignoring documentation for publicly exported types. This PR tracks anything in docs/**/types and regenerates the docs for next and 5.7.

Is there new documentation needed for these changes?

no.

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

durran
durran previously approved these changes Aug 18, 2023
@durran durran self-assigned this Aug 18, 2023
@durran durran added the Team Review Needs review from team label Aug 18, 2023
alexbevi
alexbevi previously approved these changes Aug 18, 2023
@durran
Copy link
Member

durran commented Aug 21, 2023

@baileympearson Can you fix the conflict and then I'll merge? Thanks!

@baileympearson baileympearson dismissed stale reviews from alexbevi and durran via 27dfad2 August 21, 2023 17:09
@baileympearson baileympearson requested a review from durran August 21, 2023 17:09
@durran durran merged commit 11682d0 into main Aug 21, 2023
@durran durran deleted the NODE-5532-fix-docs branch August 21, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants