Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(NODE-5523): add component support matrix to readme #3806

Merged
merged 11 commits into from
Aug 15, 2023
Merged

docs(NODE-5523): add component support matrix to readme #3806

merged 11 commits into from
Aug 15, 2023

Conversation

dariakp
Copy link
Contributor

@dariakp dariakp commented Aug 10, 2023 •
edited
Loading

Description

NODE-5523

What is changing?

Added table with version compat info for add-on packages

Is there new documentation needed for these changes?

This is documentation

What is the motivation for this change?

Clarity about add-on compatibility

Release Highlight - N/A

Double check the following

  • [N/A] Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • [N/A] Changes are covered by tests
  • [N/A] New TODOs have a related JIRA ticket

alexbevi
alexbevi reviewed Aug 10, 2023
View reviewed changes
@dariakp dariakp marked this pull request as ready for review August 10, 2023 20:44
alexbevi
alexbevi previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@alexbevi alexbevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change then LGTM

durran
durran requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks good, just one comment. Also the JIRA ticket is a blank slate so not sure if this matches the acceptance criteria or not.

@durran durran self-assigned this Aug 10, 2023
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 10, 2023
nbbeeken
nbbeeken requested changes Aug 11, 2023
View reviewed changes
nbbeeken
nbbeeken requested changes Aug 11, 2023
View reviewed changes
@dariakp @durran
Update README.md
2a64dce 
Co-authored-by: Durran Jordan <durran@gmail.com>
dariakp and others added 2 commits August 11, 2023 15:38
@dariakp
docs: adjust compat table for bson and bson-ext
8e52b26
@dariakp @nbbeeken
Update README.md
7d44569 
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
@dariakp dariakp requested review from durran and nbbeeken August 11, 2023 19:41
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 14, 2023
@durran durran merged commit 2fbb715 into main Aug 15, 2023
@durran durran deleted the NODE-5523/readme-component-support branch August 15, 2023 05:02
baileympearson pushed a commit that referenced this pull request Aug 15, 2023
@dariakp @durran
@nbbeeken @baileympearson
docs(NODE-5523): add component support matrix to readme (#3806)
1f228db 
Co-authored-by: Durran Jordan <durran@gmail.com>
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@alexbevi alexbevi alexbevi left review comments

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dariakp @durran @alexbevi @nbbeeken