Skip to content

feat(NODE-3989)!: only accept true and false for boolean options #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 4, 2023
Merged

feat(NODE-3989)!: only accept true and false for boolean options #3791

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
71bb195
feat(NODE-3989)!: only accept true and false for boolean options
W-A-James Aug 2, 2023
7969c7b
test(NODE-3989): update unit test
W-A-James Aug 2, 2023
6d4d244
test(NODE-3989): skip spec test
W-A-James Aug 2, 2023
5d8731d
Update test/unit/connection_string.test.ts
W-A-James Aug 3, 2023
0d15358
test(NODE-3989): expand on skipp comment
W-A-James Aug 3, 2023
765d643
style(NODE-3989): eslint
W-A-James Aug 3, 2023
0ab12ff
Merge branch 'main' into NODE-3989
durran Aug 4, 2023
fdeea7e
Merge branch 'main' into NODE-3989
durran Aug 4, 2023
e44dd06
Merge branch 'main' into NODE-3989
durran Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(NODE-3989): skip spec test
  • Loading branch information
@W-A-James
W-A-James committed Aug 2, 2023
commit 6d4d24429f3c38ae71086b6de0c3b60c2e1a78ae
5 changes: 4 additions & 1 deletion test/unit/assorted/uri_options.spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ describe('URI option spec tests', function () {
'tlsDisableCertificateRevocationCheck can be set to true',
'tlsDisableCertificateRevocationCheck can be set to false',
'tlsDisableOCSPEndpointCheck can be set to true',
'tlsDisableOCSPEndpointCheck can be set to false'
'tlsDisableOCSPEndpointCheck can be set to false',

// Skipped because we now only accept true/false for boolean options
'Invalid loadBalanced value'
];

const testsThatDoNotThrowOnWarn = [
Expand Down