ci(NODE-5269): Add Node 20 to driver ci #3664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
changed the title
W-A-James
changed the title
W-A-James
commented
May 10, 2023
| @@ -28,11 +28,12 @@ curl "${CURL_FLAGS[@]}" "https://nodejs.org/dist/index.tab" --output node_index. | |||
|
|
|||
| while IFS=$'\t' read -r -a row; do | |||
| node_index_version="${row[0]}" | |||
| node_index_major_version=$(echo $node_index_version | sed -E 's/^v([0-9]+).*$/\1/') | |||
There was a problem hiding this comment.
This sed invocation extracts the major version
durran
requested changes
May 12, 2023
.evergreen/run-kerberos-tests.sh
Outdated
| @@ -24,8 +24,11 @@ set -o xtrace | |||
| npm install kerberos@">=2.0.0-beta.0" | |||
| npm run check:kerberos | |||
|
|
|||
| npm install kerberos@"^1.1.7" | |||
| npm run check:kerberos | |||
| if [ "$NODE_LTS_VERSION" != "latest" ] || [ $NODE_LTS_VERSION -lt 20 ]; then | |||
There was a problem hiding this comment.
This will attempt to install 1.1.7 because "20" != "latest" - the kerberos tests then fail.
There was a problem hiding this comment.
durran
added
the
Primary Review
durran
force-pushed
the
NODE-5269/add_node_20_to_node_driver_main_ci
branch
from
36c6131 to
46cf6cc
Compare
durran
added
Team Review
nbbeeken
approved these changes
May 17, 2023
There was a problem hiding this comment.
LGTM, logging the flakes and I'll merge
And we have: https://jira.mongodb.org/browse/NODE-5293 for the windows node14 issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
.evergreen/ci_matrix_constants.jsto include Node 20 and regenerate.evergreen/config.ymlNODE_LTS_VERSIONrather thanNODE_LTS_NAMEto fix issue when trying to fetch Node 20Is there new documentation needed for these changes?
No
What is the motivation for this change?
Ensure that the driver and its extensions are compatible with the latest officially released Node.js version.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript