Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4867)!: adopt BSON v5 #3490

Merged
merged 18 commits into from
Jan 20, 2023
Merged

feat(NODE-4867)!: adopt BSON v5 #3490

merged 18 commits into from
Jan 20, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 19, 2022 •
edited
Loading

Description

What is changing?

Pulls in BSON v5 alpha.3, we're good to merge that version to main, we have a follow up ticket to make it 5.0.0 before releasing driver 5.0.0.

  • Add a few of buffer type agnostic helpers
  • Fix type issues from the new BSON version
  • Omit useBigInt64 from our supported options, this is followup work
  • ❗ Adds BSON the namespace to our public API, which makes BSON.EJSON available as well

What is the motivation for this change?

BSON v5 is really cool

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken added the wip label Dec 19, 2022
@nbbeeken nbbeeken force-pushed the NODE-4867-bson-v5 branch 4 times, most recently from 312de3a to 9d9babb Compare January 17, 2023 19:15
@nbbeeken nbbeeken changed the title feat(NODE-4867)!: WIP Testing BSON v5 DO NOT MERGE feat(NODE-4867)!: adopt BSON v5 Jan 20, 2023
@nbbeeken nbbeeken marked this pull request as ready for review January 20, 2023 18:42
@nbbeeken nbbeeken removed the wip label Jan 20, 2023
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 20, 2023
@nbbeeken nbbeeken requested a review from dariakp January 20, 2023 21:56
dariakp
dariakp requested changes Jan 20, 2023
View reviewed changes
src/cmap/auth/mongodb_aws.ts Show resolved Hide resolved
test/integration/client-side-encryption/client_side_encryption.spec.test.ts Show resolved Hide resolved
test/integration/crud/insert.test.js Show resolved Hide resolved
test/integration/objectid.test.ts Outdated Show resolved Hide resolved
test/integration/objectid.test.ts Show resolved Hide resolved
test/tools/spec-runner/matcher.js Show resolved Hide resolved
test/unit/bson.test.ts Show resolved Hide resolved
@nbbeeken nbbeeken requested a review from dariakp January 20, 2023 22:46
dariakp
dariakp previously approved these changes Jan 20, 2023
View reviewed changes
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 20, 2023
@dariakp dariakp merged commit b850868 into main Jan 20, 2023
@dariakp dariakp deleted the NODE-4867-bson-v5 branch January 20, 2023 23:40
@JoCat JoCat mentioned this pull request Mar 16, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @dariakp