Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4555): export BSON internally #3367

Merged
merged 3 commits into from
Aug 17, 2022
Merged

fix(NODE-4555): export BSON internally #3367

merged 3 commits into from
Aug 17, 2022

Conversation

durran
Copy link
Member

@durran durran commented Aug 17, 2022 •
edited
Loading

Description

Exports BSON from the library so that it can be used in other modules that depend on mongodb, such as mongodb-client-encryption.

See mongodb/libmongocrypt#443 for the libmongocrypt changes.

Patch build against this branch from libmongocrypt: https://spruce.mongodb.com/version/62fd246f3627e0758c2439c8/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

What is changing?

  • Exports BSON from the library.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4516/NODE-4555

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran mentioned this pull request Aug 17, 2022
Merged
nbbeeken
nbbeeken previously approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I checked the compiled definitions and BSON is omitted from the type defs

@nbbeeken nbbeeken added the Team Review Needs review from team label Aug 17, 2022
baileympearson
baileympearson previously requested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops wrong PR

@baileympearson baileympearson dismissed their stale review August 17, 2022 18:56

accidentally reviewed

dariakp
dariakp requested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have its own ticket for review tracking purposes since this is a multi-PR fix

@durran durran changed the title fix(NODE-4516): export BSON internally fix(NODE-4555): export BSON internally Aug 17, 2022
@durran
Copy link
Member Author

durran commented Aug 17, 2022

this should have its own ticket for review tracking purposes since this is a multi-PR fix

@dariakp Now tracked in NODE-4555

@durran durran requested a review from dariakp August 17, 2022 20:03
@dariakp dariakp merged commit 4ce6e4c into main Aug 17, 2022
@dariakp dariakp deleted the NODE-4516 branch August 17, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@baileympearson baileympearson baileympearson left review comments

@nbbeeken nbbeeken nbbeeken left review comments

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@durran @nbbeeken @baileympearson @dariakp