feat(NODE-4484): add experimental support for disambiguatedPaths in change stream documents #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-4484-updateDescription-field-enhancement
branch
from
eee0b08
to
a065cfb
Compare
baileympearson
changed the title
Merged
5 tasks
durran
added
the
Primary Review
|
Just linking to the tests passing in evg against latest: https://evergreen.mongodb.com/task_log_raw/mongo_node_driver_next_ubuntu_18.04_erbium_test_latest_replica_set_patch_f28ba0de3bc925267a185965eb971ecf91bc2680_62fd236be3c3313be42d354a_22_08_17_17_20_44/0?type=T#L838 |
durran
added
Team Review
durran
force-pushed
the
NODE-4484-updateDescription-field-enhancement
branch
from
a4ab9ff
to
565fd4f
Compare
durran
previously approved these changes
Aug 19, 2022
|
CSFLE pinned commit tests will fail after the rebase of mongodb/libmongocrypt#443 - the sha1 doesn't exist anymore after the squash/rebase of that PR but does not affect this PR. |
dariakp
requested changes
Aug 22, 2022
|
@baileympearson Should this really be a "test" and not a "feat" commit? Experimental or not, it's still not a test-only commit. I also noticed a curious failure - a cursor exhausted test - has that been already investigated and logged a flaky issue? |
baileympearson
changed the title
baileympearson
force-pushed
the
NODE-4484-updateDescription-field-enhancement
branch
from
565fd4f
to
eadb104
Compare
dariakp
approved these changes
Aug 22, 2022
baileympearson
commented
Aug 22, 2022
durran
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR is a POC PR for mongodb/specifications#1292.
A new field is supported on change stream update documents on servers >= 6.1.0 when
showExpandedEventsis true. This PR adds new spec tests for the new field and documents the new property on theUpdateDescriptiontype, marked as experimental.A follow up ticket has been filed to remove the experimental tag after the 6.1 release - https://jira.mongodb.org/browse/NODE-4554.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
https://jira.mongodb.org/browse/DRIVERS-2344.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>