feat(NODE-3132): Add TypedEventEmitter #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-3132/typed-events
branch
3 times, most recently
from
76b5075
to
e636d1e
Compare
nbbeeken
requested review from
a team,
emadum and
dariakp
and removed request for
a team
dariakp
requested changes
Apr 22, 2021
emadum
approved these changes
May 5, 2021
Using a mapped type of event names to function type can now provide annotations and completion for event argument types. Breaking Changes: - Topology open event emits one argument which is the topology itself - srvPollingHandler on topology now emits TopologyDescriptionChange event (erroneously was serverDescriptionChanged)
nbbeeken
force-pushed
the
NODE-3132/typed-events
branch
from
985cb9e
to
187e1d7
Compare
dariakp
requested changes
May 7, 2021
dariakp
reviewed
May 7, 2021
dariakp
reviewed
May 7, 2021
|
Not sure why but EVG failed to run here. |
dariakp
reviewed
May 11, 2021
|
Per discussion, let's create 2 tickets to fix the bugs uncovered by typescript and keep the changes in this PR non-breaking |
nbbeeken
changed the title
|
@dariakp Looks like the revert passes if you wanted to take another look here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a mapped type of event names to function type can now provide
annotations and completion for event argument types.
Breaking Changes:Topology open event emits one argument which is the topology itselfsrvPollingHandler on topology now emits TopologyDescriptionChange event (erroneously was serverDescriptionChanged)