Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reintroduce nodejs fermium testing #2775

Merged
merged 2 commits into from
Apr 5, 2021
Merged

chore: reintroduce nodejs fermium testing #2775

merged 2 commits into from
Apr 5, 2021

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Apr 1, 2021

Somehow I dropped fermium testing, bringing it back here.

@nbbeeken nbbeeken requested review from durran and emadum April 1, 2021 16:17
@emadum emadum self-requested a review April 2, 2021 18:06
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we restrict the tests that fail on fermium to node<14 and add a ticket to fix them?

@nbbeeken
Copy link
Contributor Author

nbbeeken commented Apr 2, 2021

Can we restrict the tests that fail on fermium to node<14 and add a ticket to fix them?

Excellent idea, went and did that, so the remaining errors are on macos only and look like the typical flakiness we usually see there.

@nbbeeken nbbeeken requested a review from emadum April 2, 2021 19:40
@nbbeeken nbbeeken merged commit 5a0d706 into 3.6 Apr 5, 2021
@nbbeeken nbbeeken deleted the chore/fix-ci branch April 5, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants