Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move session support check to operation layer #2739

Merged
merged 5 commits into from
Mar 11, 2021
Merged

fix: move session support check to operation layer #2739

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb14ee3
fix: move session support check to operation layer
nbbeeken Feb 16, 2021
8b4e695
Move session support check into server selection for unified topology
nbbeeken Feb 17, 2021
8a0e3ef
fix: update to simple fix
nbbeeken Mar 3, 2021
f621a49
refactor to use maybePromise, clean up comments and organize control …
nbbeeken Mar 9, 2021
b22fe87
fix: maybePromise refactor passes undefined to callbacks
nbbeeken Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move session support check into server selection for unified topology
  • Loading branch information
@nbbeeken
nbbeeken committed Mar 5, 2021
commit 8b4e69543f1a63dc39e3dc9f64c5f0cb3ca92aa2
4 changes: 4 additions & 0 deletions lib/operations/execute_operation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ function executeWithServerSelection(topology, operation, callback) {
return;
}

if (serverSelectionOptions.session && topology.hasSessionSupport()) {
return callback(new MongoError('Current topology does not support sessions'));
}

const shouldRetryReads =
topology.s.options.retryReads !== false &&
operation.session &&
Expand Down