Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE-2825: Add tests for azure and GCP CSFLE #2662

Merged
merged 6 commits into from
Jan 13, 2021

Conversation

mbroadst
Copy link
Member

@mbroadst mbroadst commented Dec 4, 2020

This is the testing component for the fixes which were merged and published in the libmongocrypt bindings. The patch adds new automated YAML tests, as well as required changes to the prose tests.

@mbroadst mbroadst requested review from emadum and nbbeeken December 4, 2020 19:01
@mbroadst mbroadst force-pushed the NODE-2825/csfle-azure-gcp-support branch 2 times, most recently from cedfcc2 to fabd1bb Compare December 4, 2020 21:11
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but oddly it seems from CI that a replica set test is now leaking a client.

@mbroadst mbroadst force-pushed the NODE-2825/csfle-azure-gcp-support branch from fabd1bb to 0412809 Compare January 12, 2021 20:26
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mbroadst mbroadst merged commit 7e89e47 into 3.6 Jan 13, 2021
@mbroadst mbroadst deleted the NODE-2825/csfle-azure-gcp-support branch January 13, 2021 14:10
emadum added a commit that referenced this pull request Feb 12, 2021
This adds new tests, and modifies the test runner to account for the recent
addition of Azure and GCP CSFLE support in the CSLFE specification.

NODE-2825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants