refactor: move find command building all into the find operation #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
requested changes
Dec 1, 2020
mbroadst
force-pushed
the
NODE-2900/query-find-operation-merge
branch
from
6c723d3
to
b66c07a
Compare
emadum
approved these changes
Dec 1, 2020
src/operations/find.ts
Outdated
|
|
||
| if (options.projection) { | ||
| let projection = options.projection; | ||
| if (projection && !Buffer.isBuffer(projection) && Array.isArray(projection)) { |
There was a problem hiding this comment.
Suggested change
| if (projection && !Buffer.isBuffer(projection) && Array.isArray(projection)) { | |
| if (projection && Array.isArray(projection)) { |
Nit: Shouldn't Array.isArray imply !Buffer.isBuffer?
src/operations/find.ts
Outdated
|
|
||
| if (typeof options.limit === 'number') { | ||
| if (options.limit < 0) { | ||
| findCommand.limit = Math.abs(options.limit); |
There was a problem hiding this comment.
Suggested change
| findCommand.limit = Math.abs(options.limit); | |
| findCommand.limit = -options.limit; |
Nit: I'd guess using the - operator is faster than Math.abs when we know something is negative, but also probably a fairly negligible improvement. Also applies below in the options.batchSize < 0 condition.
There was a problem hiding this comment.
fixed. I left two Math.abs in there where I felt it improved readability (Math.abs(batchSize) < Math.abs(limit) looks better than -batchSize < -limit IMO)
One of the changes made in merging the core and native drivers was to merge the wire protocol methods for executing find operations. A vestigial piece of this was that the find command was being built in the wire protocol layer, rather than the operation layer. This patch teases these two apart, so that the `query` wire protocol method only creates and executes an `OP_QUERY` message, and the modern and legacy find commands are built in the find operation's definition itself. NODE-2900
mbroadst
force-pushed
the
NODE-2900/query-find-operation-merge
branch
from
b66c07a
to
eb020e0
Compare
nbbeeken
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the changes made in merging the core and native drivers was to merge the wire protocol methods for executing find operations. A vestigial piece of this was that the find command was being built in the wire protocol layer, rather than the operation layer. This patch teases these two apart, so that the
querywire protocol method only creates and executes anOP_QUERYmessage, and the modern and legacy find commands are built in the find operation's definition itself.NODE-2900