Skip to content

MONGOID-4998 Drop support for the :id_sort option and only accept positional argument #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 12, 2022
Merged

MONGOID-4998 Drop support for the :id_sort option and only accept positional argument #5362

merged 7 commits into from
Jul 12, 2022

Conversation

neilshweky
Copy link
Contributor

@neilshweky neilshweky commented Jul 7, 2022 •
edited
Loading

#5358 has to be done first.

p-mongo
p-mongo approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@p-mongo p-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a release note that id_sort is removed right?

@neilshweky
Copy link
Contributor Author

This needs a release note that id_sort is removed right?

done

@neilshweky neilshweky merged commit 7d209fe into mongodb:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-mongo p-mongo p-mongo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilshweky @p-mongo