Add a more descriptive error when spec load fails #5066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
p-mongo
reviewed
Sep 6, 2021
| raise LoadError.new <<~MSG.strip | ||
| The test suite requires shared tooling to be installed. | ||
| Please refer to spec/README.md for instructions. | ||
| MSG |
There was a problem hiding this comment.
Thank you for this change, I think it is helpful.
Can you please include the original exception message in the new exception message using a pattern like
rescue LoadError => exc
raise LoadError, "...: #{exc.class}: #{exc}"
There was a problem hiding this comment.
In this case, since this is purely for development users in the console, I don't think it's useful to include the original error--it just makes it harder to read.
(If the original error was intelligible, I wouldn't have to make this PR :)
comandeo
approved these changes
Oct 1, 2021
p-mongo
pushed a commit
that referenced
this pull request
Oct 4, 2021
* Raise a friendlier load error when running specs so that outside contributors know what to do. * show original exception Co-authored-by: shields <shields@tablecheck.com> Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com> Co-authored-by: Oleg Pudeyev <code@olegp.name>
p-mongo
pushed a commit
to p-mongo/mongoid
that referenced
this pull request
Oct 4, 2021
* Raise a friendlier load error when running specs so that outside contributors know what to do. * show original exception Co-authored-by: shields <shields@tablecheck.com> Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com> Co-authored-by: Oleg Pudeyev <code@olegp.name>
p-mongo
pushed a commit
to johnnyshields/mongoid
that referenced
this pull request
Oct 5, 2021
* master: Remove remaining encoding declarations (mongodb#5088) Add a more descriptive error when spec load fails (mongodb#5066) MONGOID-5191 Proper order for after_create callback (mongodb#5087) MONGOID-5189 Proper order of *_save callbacks (mongodb#5083) MONGOID-5098 Standardize/improve Range queries -- .where(field: 1..3) (mongodb#5025)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a friendlier load error when running specs so that outside contributors know what to do.