Allow configuration of embedded models to fire callbacks on parent save (#237) #1058
Conversation
|
+1 |
|
This looks great, @pyromaniac! All of the specs pass for me. I'd like one or two other core team members to examine this before it's pulled in because it changes some very important parts of Mongoid. |
|
+1 |
|
This is definitely needed! +1 |
|
@nickhoffman Looks good to me.! |
|
+1 |
|
Once I've finished the 3 issues left for 2.1.0 I'll grab this. |
|
@durran Would you like me to merge this in, or would you prefer to comb through the changes yourself? |
|
I'll pull it in once I get the identity map integration branch in - there will be some conflicts. |
|
Sounds good! |
|
Ooo I need this right now! |
|
This is the 2.1.2 tag with this branch merged on top, if it spares anyone else the trouble of doing the same thing: https://github.com/ches/mongoid/tree/v212-cascade-callbacks/ There were no merge conflicts and 0 test failures on 1.9.2-p290. |
|
Oh, thank you, also here is patch rebased on mongoid master |
|
+1 |
|
Since pull requests aren't listed in the issues list, and thus can't be tagged with a milestone, I've created issue #1250 to give this pull request more attention. |
|
+1 |
- This includes the original pull request, plus rebases from many contributing to the request, plus my refactors and extended test coverage and rdoc. - This does not include multi-level nested documents. - This does not include prevention of double calls on new child save.
Allow configuration of embedded models to fire callbacks on parent save (#237)
This is the same patch, but i've made it more actual