Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validateSpec to return error last #1684

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Update validateSpec to return error last #1684

merged 1 commit into from
Mar 7, 2025

Conversation

m1kola
Copy link
Collaborator

@m1kola m1kola commented Mar 7, 2025 •
edited
Loading

Just fixes go-staticcheck warning which complains about error not being last return value:

error should be returned as the last argument (ST1008)

@m1kola m1kola added the safe-to-test Add this label to PRs from forks to trigger E2E tests label Mar 7, 2025
@m1kola m1kola force-pushed the fixup_validateSpec branch from ee83035 to 883e113 Compare March 7, 2025 14:58
@m1kola m1kola added safe-to-test Add this label to PRs from forks to trigger E2E tests and removed safe-to-test Add this label to PRs from forks to trigger E2E tests labels Mar 7, 2025
@m1kola m1kola merged commit 7a5cd08 into mongodb:master Mar 7, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciejKaras MaciejKaras MaciejKaras approved these changes

@nammn nammn nammn approved these changes

@mircea-cosbuc mircea-cosbuc Awaiting requested review from mircea-cosbuc mircea-cosbuc is a code owner

@lsierant lsierant Awaiting requested review from lsierant lsierant is a code owner

@Julien-Ben Julien-Ben Awaiting requested review from Julien-Ben Julien-Ben is a code owner

@lucian-tosa lucian-tosa Awaiting requested review from lucian-tosa lucian-tosa is a code owner

@fealebenpae fealebenpae Awaiting requested review from fealebenpae fealebenpae is a code owner

Assignees
No one assigned
Labels
safe-to-test Add this label to PRs from forks to trigger E2E tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m1kola @MaciejKaras @nammn