Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-128701: Use Go 1.18 #604

Merged
merged 2 commits into from
Jul 20, 2022
Merged

CLOUDP-128701: Use Go 1.18 #604

merged 2 commits into from
Jul 20, 2022

Conversation

igor-karpukhin
Copy link
Collaborator

All Submissions:

Some linters were disabled as they don't support Go 1.18. See: golangci/golangci-lint#2649

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

fabritsius
fabritsius approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@fabritsius fabritsius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great 👍

I think we should also change the Dockerfile:

FROM golang:1.17 as builder

Sugar-pack
Sugar-pack reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@Sugar-pack Sugar-pack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

Go 1.17 is also in the Dockerfiles: .github/action/deploy/Dockerfile, .github/actions/gen-install-scripts/Dockerfile, .github/actions/int-test/Dockerfile. Perhaps it's worth changing the version there?

Sugar-pack
Sugar-pack approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@Sugar-pack Sugar-pack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igor-karpukhin igor-karpukhin merged commit e49ca89 into main Jul 20, 2022
@igor-karpukhin igor-karpukhin deleted the feature/go-1.18 branch July 20, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sugar-pack Sugar-pack Sugar-pack approved these changes

@Julien-Ben Julien-Ben Julien-Ben approved these changes

@fabritsius fabritsius fabritsius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igor-karpukhin @fabritsius @Julien-Ben @Sugar-pack