Added helm post install hook #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Jan 27, 2022
| @@ -1,7 +1,7 @@ | |||
| # checkout other hooks in https://pre-commit.com/hooks.html | |||
| repos: | |||
| - repo: https://github.com/golangci/golangci-lint | |||
| rev: v1.36.0 | |||
| rev: v1.44.0 | |||
There was a problem hiding this comment.
1.36.0 was not working on macOS
leo-ri
approved these changes
Jan 31, 2022
chatton
deleted the
CLOUDP-90704_helm_should_return_after_cluster_creation
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
This PR introduces a new image. This image contains a binary which waits until an AtlasCluster reaches the ready state. Helm will not exit until it timeouts, or the clusters specified in Values.yaml are ready to serve traffic.
The new image can be found here https://quay.io/repository/mongodb/atlas-operator-post-install-hook?tab=tags
As we now have multiple
main.gos. I've moved both undercmdand updated the corresponding paths.closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).