CLOUDP-261715: Enabled resync for Atlas custom resources #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
approved these changes
Jul 18, 2024
s-urbaniak
requested changes
Jul 18, 2024
|
re 2.: for now, we shouldn't expose the knob to main just yet but just for the e2e test. |
|
@s-urbaniak the sync interval is already configurable. The main just doesn't set it and it's set up to the default value of 3 hours |
I just checked that locally, and it doesn't double the reconciliations. It doubles them if we actually remove the predicated |
s-urbaniak
reviewed
Jul 19, 2024
josvazg
reviewed
Jul 19, 2024
|
|
||
| var _ = Describe("Sync Period test", Label("int", "sync-period"), func() { | ||
| const interval = time.Second * 2 | ||
| const syncInterval = 40 * time.Second |
There was a problem hiding this comment.
nit pick
would 10s be enough to test the same?
There was a problem hiding this comment.
As a side note: i am working on a pure unit-test approach for this. I don't think we need a full blown e2e test to assert resyncs. I will submit once ready.
josvazg
approved these changes
Jul 19, 2024
s-urbaniak
approved these changes
Jul 24, 2024
Co-authored-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
igor-karpukhin
force-pushed
the
CLOUDP-261715/fix-sync-interval
branch
from
69d965c
to
7f97c67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one). Closes AtlasDatabaseUser is not reconciled periodically - manual changes are not overridden until pod restart #1689