CLOUDP-269300: Bump to Go 1.23 (#1841)

* Bump Go & golangci

* Replace deprecated linter

* Remedy linter errors

* Update licenses

* Move to go 1.23

* Try fix the licenses issue

* Bump all images to 1.23 also

* Apply suggestions from code review

Use %w for error wrapping

Co-authored-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>

* Apply suggestions from code review

Revert to use `%s` again, because `stat.Error` is a `string` and thus cannot be wrapped as an error.

---------

Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
Co-authored-by: jose.vazquez <jose.vazquez@mongodb.com>
Co-authored-by: Sergiusz Urbaniak <sergiusz.urbaniak@gmail.com>

.github/actions/gen-install-scripts/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22
+FROM golang:1.23
 
 ENV KUBECTL_VERSION 1.18.12
 ENV GO111MODULE on

.golangci.yml

@@ -7,7 +7,7 @@ linters:
     - dupl
     - errcheck
     - errorlint
-    - exportloopref
+    - copyloopvar
     #- gocritic
     - gocyclo
     - goimports

.licenses-gomod.sha256

@@ -1 +1 @@
-100644 c4cf9120e81ef4e31f288eef5adccbba2862f023 go.mod
+100644 6a6da89744c37c3cd16ce3e453f217e5927c2860 go.mod

Dockerfile.post-install

@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.22 as builder
+FROM golang:1.23 as builder
 
 ENV CGO_ENABLED=0
 ENV GOOS=linux

Makefile

@@ -84,6 +84,7 @@ ATLAS_KEY_SECRET_NAME = mongodb-atlas-operator-api-key
 
 BASE_GO_PACKAGE = github.com/mongodb/mongodb-atlas-kubernetes/v2
 GO_LICENSES = go-licenses
+GO_LICENSES_VERSION = 1.6.0
 KUSTOMIZE = kustomize
 DISALLOWED_LICENSES = restricted,reciprocal
 
@@ -126,9 +127,9 @@ all: manager ## Build all binaries
 build-licenses.csv: go.mod ## Track licenses in a CSV file
 	@echo "Tracking licenses into file $@"
 	@echo "========================================"
-	GOOS=linux GOARCH=amd64 go mod download
-	# https://github.com/google/go-licenses/issues/244
-	GOTOOLCHAIN=local GOOS=linux GOARCH=amd64 $(GO_LICENSES) csv --include_tests $(BASE_GO_PACKAGE)/... > licenses.csv
+	export GOOS=linux
+	export GOARCH=amd64
+	go run github.com/google/$(GO_LICENSES)@v$(GO_LICENSES_VERSION) csv --include_tests $(BASE_GO_PACKAGE)/... > licenses.csv
 	echo $(GOMOD_SHA) > $(LICENSES_GOMOD_SHA_FILE)
 
 .PHONY: recompute-licenses
@@ -145,8 +146,9 @@ licenses-up-to-date: ## Check if the licenses.csv is up to date
 check-licenses: licenses-up-to-date ## Check licenses are compliant with our restrictions
 	@echo "Checking licenses not to be: $(DISALLOWED_LICENSES)"
 	@echo "============================================"
-	# https://github.com/google/go-licenses/issues/244
-	GOTOOLCHAIN=local GOOS=linux GOARCH=amd64 $(GO_LICENSES) check --include_tests \
+	export GOOS=linux
+	export GOARCH=amd64
+	go run github.com/google/$(GO_LICENSES)@v$(GO_LICENSES_VERSION) check --include_tests \
 	--disallowed_types $(DISALLOWED_LICENSES) $(BASE_GO_PACKAGE)/...
 	@echo "--------------------"
 	@echo "Licenses check: PASS"

devbox.json

@@ -3,7 +3,7 @@
     "yq-go@latest",
     "kubebuilder@4.1.1",
     "jq@latest",
-    "go@1.22.5",
+    "go@1.23",
     "gotests@latest",
     "act@latest",
     "kubectl@latest",
@@ -16,11 +16,10 @@
     "kubernetes-helm@latest",
     "govulncheck@latest",
     "gotools@latest",
-    "go-licenses@latest",
     "ginkgo@latest",
     "operator-sdk@1.36.1",
     "shellcheck@latest",
-    "golangci-lint@1.59.1",
+    "golangci-lint@1.60",
     "kubernetes-controller-tools@0.16.1"
   ]
 }