fix Arbitrary file access during archive extraction ("Zip Slip") #809
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mongo-tools/release/release.go
Lines 1527 to 1532 in f76a3ae
Extracting files from a malicious zip file, or similar type of archive, is at risk of directory traversal attacks if filenames from the archive are not properly validated. archive paths.
Fix the issue need to validate the
header.Name
field to ensure it does not contain directory traversal elements (..
) or absolute paths. This can be achieved by:filepath.Clean
to normalize the path.dst
).The fix involves:
header.Name
usingfilepath.Clean
.path
) and ensuring it is within thedst
directory by checking that the cleaned path starts with thedst
prefix.Zip Slip Vulnerability