SWIFT-1470 Fix failing load balancer tests #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
force-pushed
the
SWIFT-1470/fix-lb-tests
branch
from
99fd1ab to
a5faaa9
Compare
patrickfreed
commented
Feb 24, 2022
| helloReply["isreplicaset"] != true | ||
| { | ||
| self = .single | ||
| // TODO: SWIFT-1319: eventually, we should be able to just check for serviceId here. |
Contributor
Author
There was a problem hiding this comment.
as discussed offline, serviceId only shows up in the initial handshake, so we can't check for it here and need to still rely on the environment variable.
patrickfreed
requested review from
isabelatkinson and
kmahar
and removed request for
kmahar
kmahar
approved these changes
Feb 24, 2022
| git apply ${ETC_DIR}/lower-minheartbeatfrequencyms.diff | ||
| git apply ${ETC_DIR}/inttypes-non-modular-header-workaround.diff | ||
| # TODO SWIFT-1319: Remove. | ||
| git apply ${ETC_DIR}/expose-mock-service-id.diff |
Contributor
There was a problem hiding this comment.
should we delete this diff file now too?
isabelatkinson
approved these changes
Feb 24, 2022
Contributor
isabelatkinson
left a comment
isabelatkinson
left a comment
There was a problem hiding this comment.
lgtm mod kaitlin's comment
kmahar
pushed a commit
that referenced
this pull request
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT-1470 / SWIFT-1319