SWIFT-1061 Update r1.0 branch to support matrix testing #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Feb 10, 2021
|
|
||
| # this is set by drivers-matrix-testing, and it's a special variable used in swiftenv | ||
| # leaving it set messes with the installation | ||
| unset PLATFORM |
Contributor
Author
There was a problem hiding this comment.
this shouldn't affect the test suite if it needs access to $PLATFORM, since we run install-dependencies.sh in its own shell
kmahar
approved these changes
Feb 11, 2021
patrickfreed
added a commit
that referenced
this pull request
Feb 11, 2021
This also completes SWIFT-763.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT-1061
This PR makes the following changes to the r1.0 branch to support continuous matrix testing:
run-tests.shvia theINSTALL_DEPSvariableinstall-dependencies.shto avoid a clash between matrix testsing's$PLATFORMand the$PLATFORMused in swiftenvmainas well)Example matrix patch: https://spruce.mongodb.com/version/60246becd6d80a75c95f89f1/tasks
Example r1.0 patch: https://spruce.mongodb.com/version/602475c03627e06ab8f78190/tasks