Skip to content

Conversation

@kmahar
Copy link
Contributor

@kmahar kmahar commented Sep 30, 2020

The old patch just seemed to be too out of date to apply cleanly to about half of the files; I think a lot of them had added a number of include statements at the top so the line numbers were off.

I just manually updated the necessary files here and then used that to generate a new patch.

@kmahar kmahar requested a review from patrickfreed September 30, 2020 21:43
@codecov-commenter
Copy link

Codecov Report

Merging #530 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files         132      132           
  Lines       14077    14077           
=======================================
  Hits        10876    10876           
  Misses       3201     3201           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3125ff...2bc02d4. Read the comment docs.

Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff lgtm, I assume you tried this out and it works with xcode now?

@kmahar
Copy link
Contributor Author

kmahar commented Oct 1, 2020

Yes, it builds successfully. I did run into a new issue which I think may either be an Xcode 12 or Swift 5.3 bug, where we seem to only pick up on about half of the spec test files. For example Xcode says the BSON corpus test ones are missing, but it finds the command monitoring ones and runs those tests just fine.... I can't figure out what is different about the cases where it works and where it doesn't. Unfortunately the transactions tests are among those it is not finding, which is what led me down the road of trying to build in Xcode in the first place. 🤦‍♀️

Anyway, that seemed like a separate issue so I have opened SWIFT-1011 to track fixing that.

@kmahar kmahar merged commit bf20ebb into master Oct 1, 2020
@kmahar kmahar deleted the fix-inttypes branch October 1, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants