SWIFT-958 Ensure nil is returned from next() before ClosedCursorError #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Aug 24, 2020
| var count = 0 | ||
| for result in cursor { | ||
| expect(count).to(beLessThan(2)) | ||
| if count >= 2 { |
Contributor
Author
There was a problem hiding this comment.
I could not get these tests to halt after failing an expect, so I manually added breaks. I tried setting self.continueAfterFailure = false, but it didn't seem to work.
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
- Coverage 77.65% 77.65% -0.01%
==========================================
Files 130 130
Lines 13876 13910 +34
==========================================
+ Hits 10776 10802 +26
- Misses 3100 3108 +8
Continue to review full report at Codecov.
|
kmahar
approved these changes
Aug 24, 2020
| var count = 0 | ||
| for result in cursor { | ||
| expect(count).to(beLessThan(2)) | ||
| if count >= 2 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT-958
This fixes a bug where cursors would iterate forever after encountering a non-
DecodingErrorby ensuringnextreturnsnilonce after the error. This does not apply totryNextortoArray, since those arethrows. Also, in the case oftryNext,nildoesn't necessarily imply that the cursor is dead.