Skip to content

Conversation

@patrickfreed
Copy link
Contributor

@patrickfreed patrickfreed requested review from kmahar and nbbeeken May 27, 2020 17:49
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #488 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   76.89%   76.89%           
=======================================
  Files         125      125           
  Lines       13012    13012           
=======================================
  Hits        10005    10005           
  Misses       3007     3007           
Impacted Files Coverage Δ
Sources/MongoSwift/ChangeStream.swift 30.64% <ø> (ø)
Sources/MongoSwift/MongoClient.swift 87.09% <ø> (ø)
...ces/MongoSwift/MongoCollection+ChangeStreams.swift 43.75% <ø> (ø)
Sources/MongoSwift/MongoCollection+Indexes.swift 89.33% <ø> (ø)
Sources/MongoSwift/MongoCollection+Read.swift 100.00% <ø> (ø)
Sources/MongoSwift/MongoCursor.swift 100.00% <ø> (ø)
Sources/MongoSwift/MongoDatabase.swift 80.35% <ø> (ø)
Sources/MongoSwiftSync/ChangeStream.swift 0.00% <ø> (ø)
Sources/MongoSwiftSync/MongoCursor.swift 90.62% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f1fd3...52deb8e. Read the comment docs.

Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs look nicely formatted in xcode's doc popups 🚀

Copy link
Contributor

@kmahar kmahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@patrickfreed patrickfreed merged commit daa6a2c into mongodb:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants