Skip to content

Conversation

@kmahar
Copy link
Contributor

@kmahar kmahar commented May 21, 2020

Leftovers from the last PR. Adds prefixes to Document, DocumentIteraror, Decimal128, and DBPointer.
Also prefixed MinKey and MaxKey for consistency, though they are internal types.

@kmahar kmahar requested review from nbbeeken and patrickfreed May 21, 2020 23:47
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #482 into master will increase coverage by 0.02%.
The diff coverage is 84.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   76.86%   76.89%   +0.02%     
==========================================
  Files         125      125              
  Lines       13000    13012      +12     
==========================================
+ Hits         9993    10005      +12     
  Misses       3007     3007              
Impacted Files Coverage Δ
Sources/MongoSwift/BSON/CodingStrategies.swift 37.50% <ø> (ø)
Sources/MongoSwift/ChangeStream.swift 30.64% <0.00%> (ø)
Sources/MongoSwift/ChangeStreamOptions.swift 40.00% <ø> (ø)
Sources/MongoSwift/Hint.swift 53.84% <0.00%> (ø)
Sources/MongoSwift/MongoClient.swift 87.09% <0.00%> (ø)
...ces/MongoSwift/MongoCollection+ChangeStreams.swift 43.75% <ø> (ø)
...ces/MongoSwift/MongoCollection+FindAndModify.swift 98.61% <ø> (ø)
Sources/MongoSwift/MongoCredential.swift 100.00% <ø> (ø)
...oSwift/Operations/CommitTransactionOperation.swift 0.00% <0.00%> (ø)
...goSwift/Operations/CreateCollectionOperation.swift 100.00% <ø> (ø)
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79dfa37...9a40841. Read the comment docs.

Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this, we'll need to update the various guides and examples in our documentation to refer to the new types. The web framework / mongodb docs examples may need to be updated as well.

@kmahar kmahar force-pushed the SWIFT-822/prefix-remaining-types branch from 5a3c3aa to 9a40841 Compare May 26, 2020 23:42
@kmahar
Copy link
Contributor Author

kmahar commented May 26, 2020

I'm making a pass through all of our guides right now and it's turning into a rather significant endeavor as a lot of stuff is outdated, so I'll handle that in a separate PR

@kmahar
Copy link
Contributor Author

kmahar commented May 27, 2020

update: put up #486 containing guides and examples changes.

@kmahar kmahar merged commit 8435316 into master May 27, 2020
@kmahar kmahar deleted the SWIFT-822/prefix-remaining-types branch May 27, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants