Skip to content

Conversation

@patrickfreed
Copy link
Contributor

SWIFT-776

This PR adds examples of retrying transactions to the transactions guide. It does so by simply linking to the official docs, since those examples are quite thorough (and will contain the Swift examples written in #478 ).

This PR also adds clarification in the documentation about how options (e.g. write concern) are propagated in transactions. This is based off of feedback from the latest jepsen analysis of MongoDB's transactions.

@patrickfreed patrickfreed requested review from kmahar and nbbeeken May 20, 2020 21:30
@codecov-commenter
Copy link

Codecov Report

Merging #479 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   76.96%   76.85%   -0.12%     
==========================================
  Files         125      125              
  Lines       12991    12991              
==========================================
- Hits         9999     9984      -15     
- Misses       2992     3007      +15     
Impacted Files Coverage Δ
Sources/MongoSwift/ClientSession.swift 39.30% <ø> (ø)
.../MongoSwift/Operations/StartSessionOperation.swift 95.45% <ø> (ø)
Sources/MongoSwiftSync/ClientSession.swift 53.57% <ø> (ø)
Tests/MongoSwiftSyncTests/CrudTests.swift 90.90% <0.00%> (-5.69%) ⬇️
Sources/MongoSwift/MongoCollection+Write.swift 97.89% <0.00%> (ø)
Sources/MongoSwift/MongoCollection+BulkWrite.swift 85.62% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01e15a...04a837d. Read the comment docs.

@patrickfreed patrickfreed merged commit 78f1fd3 into mongodb:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants